-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pseudo-PR: First code review #10
base: first-commit
Are you sure you want to change the base?
Conversation
Functional Dockerfile
likelet#26 and a few other changes detailed there
Add per-process resource allocations
add email information
…parameter of cpat_path
BTW, I didn't add test data here, as the test data is extremely big (about 2 Gb). I created a test data repo on testdata and stored the data at a local server that allowing remote access. Plz let me know if there is an alternative strategy. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some remarks, I'll go over it in more detail later
Hosting somewhere else is fine I guess, but please still add a separate branch for lncpipe and state that in a README in that branch so that people know where the test data resides. Do you have an idea how long your tests are running? Or could you strip the dataset down in size while still running proper tests? |
Okey, i wll add a branch there. For now , the test data may take less than 10 mins with default setting . I tried stripping the dataset into chrX only for it can produce meanful result which also can promote the understanding to the result. |
The test dataset has been trimmed into 0.5Gb in total, and hosted on my own server. I also set the url in the |
rename the process name that solved the duplicated processed error by updated Nextflow version from 0.18
Co-authored-by: Phil Ewels <phil.ewels@scilifelab.se>
Update nextflow.config
Many thanks to contributing to nf-core/lncpipe!
Please fill in the appropriate checklist below (delete whatever is not relevant). These are the most common things requested on pull requests (PRs).
PR checklist
nextflow run . -profile test,docker
).nf-core lint .
).docs
is updatedCHANGELOG.md
is updatedREADME.md
is updatedLearn more about contributing: https://github.com/nf-core/lncpipe/tree/master/.github/CONTRIBUTING.md