Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add MetaEuk for Eukaryotic genome annotation #481

Merged
merged 10 commits into from
Jul 29, 2023
Merged

Add MetaEuk for Eukaryotic genome annotation #481

merged 10 commits into from
Jul 29, 2023

Conversation

prototaxites
Copy link
Contributor

@prototaxites prototaxites commented Jul 21, 2023 •
edited
Loading

Hope I caught everything but should just work. Will try and update the process diagram sometime next week, but am in the lab so will see where I can squeeze the time in!

@jfy133 Should we squeeze this one into the next release? Happy to wait, but it might be nice to tie domain classification in with a feature to justify its inclusion (beyond making DAS_tool only take prokaryotic bins).

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs- [ ] If necessary, also make a PR on the nf-core/mag branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • [] Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@github-actions
Copy link

github-actions bot commented Jul 21, 2023 •
edited
Loading

nf-core lint overall result: Passed ✅ ⚠️

Posted for pipeline commit 966984b

+| ✅ 156 tests passed       |+
#| ❔   1 tests were ignored |#
!| ❗   1 tests had warnings |!

❗ Test warnings:

  • pipeline_todos - TODO string in methods_description_template.yml: #Update the HTML below to your preferred methods description, e.g. add publication citation for this pipeline

❔ Tests ignored:

  • files_unchanged - File ignored due to lint config: lib/NfcoreTemplate.groovy

✅ Tests passed:

Run details

  • nf-core/tools version 2.9
  • Run at 2023-07-25 07:31:58

jfy133
jfy133 approved these changes Jul 21, 2023
View reviewed changes
Copy link
Member

@jfy133 jfy133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I said no more functionality but I'm dragging on and I can see your point about the benefits of including this with the domain classification stuff... but this is the last one for this release!

docs/output.md Outdated Show resolved Hide resolved
conf/modules.config Show resolved Hide resolved
jfy133
jfy133 approved these changes Jul 25, 2023
View reviewed changes
docs/output.md Outdated Show resolved Hide resolved
lib/WorkflowMag.groovy Outdated Show resolved Hide resolved
prototaxites and others added 2 commits July 25, 2023 08:26
@prototaxites @jfy133
Update lib/WorkflowMag.groovy
d398532 
Co-authored-by: James A. Fellows Yates <jfy133@gmail.com>
@prototaxites
Update output.md
966984b
@jfy133 jfy133 merged commit 0d24a2e into nf-core:dev Jul 29, 2023
15 checks passed
@prototaxites prototaxites deleted the metaeuk branch August 3, 2023 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jfy133 jfy133 jfy133 approved these changes

@d4straub d4straub Awaiting requested review from d4straub

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@prototaxites @jfy133