Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Assembly/Binning #5

Merged
merged 56 commits into from
Jan 21, 2019
Merged

Assembly/Binning #5

merged 56 commits into from
Jan 21, 2019

Conversation

HadrienG
Copy link
Member

@HadrienG HadrienG commented Oct 3, 2018 •
edited

ready for review!

@ewels ewels added the WIP Work in progress label Oct 3, 2018
@ewels ewels changed the title [WIP] Assembly/Binning Assembly/Binning Oct 3, 2018
maxulysse and others added 26 commits October 5, 2018 16:07
@maxulysse
add logo
1d62dda
@ewels
Merge pull request #6 from MaxUlysse/master
0cea483 
add logo
@maxulysse
Update README.md
4bd07ba 
fix double .png
@ewels
Merge pull request #7 from nf-core/MaxUlysse-patch-1
4d76ddb 
Update README.md
@HadrienG
assembly
bcfe9e8
@HadrienG
Merge branch 'dev' of https://github.com/nf-core/mag into dev
78851bc
@HadrienG
bump nextflow version
04374a8
@HadrienG
binning
b5b65e2
@HadrienG
switch to profile for tests
fd1432c
@HadrienG
checkm
91b0e82
@HadrienG
smaller test data
48dda34
@HadrienG
working minimal test file producing bins
b199582
@HadrienG
tool update
72d876b
@HadrienG
added fastqc
9036e7b
@HadrienG
added quast
79b51a5
@HadrienG
checkm plots
dc4b80b
@HadrienG
added checkm refine fastp
8ab82c5
@HadrienG
atropos -> fastp
d0f5800
@HadrienG
check automatic bin merghing
1137772
@HadrienG
into -> from
34322fe
@HadrienG
no need for subdir
16f1e73
@HadrienG
fix bin input
0aacffd
@HadrienG
debug checkm
8e73342
@HadrienG
do not need custome checkm docker anymore
d9373fb
@HadrienG
refinem
1e521c1
@HadrienG
task cpus
264bb01
@HadrienG
Copy link
Member Author

HadrienG commented Dec 6, 2018 •
edited

hej @nf-core/core ! This is more or less ready for reviewing 😄

two questions first:

  • I have docker pull issues in the CI, as nfcore/mag has no latest tag on docker hub. How do I go with that?
  • my repo has been updated with a template branch a long, long while ago. Should I redo a manual update or we'll fix that later?

Best,
Hadrien

apeltzer
apeltzer requested changes Dec 13, 2018
View reviewed changes
.travis.yml Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
Dockerfile Outdated Show resolved Hide resolved
Dockerfile Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
Singularity Outdated Show resolved Hide resolved
environment.yml Outdated Show resolved Hide resolved
nextflow.config Outdated Show resolved Hide resolved
nextflow.config Outdated Show resolved Hide resolved
nextflow.config Outdated Show resolved Hide resolved
@HadrienG
Copy link
Member Author

HadrienG commented Jan 7, 2019 •
edited

@apeltzer I think I addressed all your comments.

(Also Happy new year! 😄 )

apeltzer
apeltzer requested changes Jan 8, 2019
View reviewed changes
Copy link
Member

@apeltzer apeltzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor stuff, not something too big :-)

README.md Outdated Show resolved Hide resolved
docs/output.md Outdated Show resolved Hide resolved
nextflow.config Show resolved Hide resolved
main.nf Outdated Show resolved Hide resolved
main.nf Show resolved Hide resolved
main.nf Show resolved Hide resolved
main.nf Outdated Show resolved Hide resolved
main.nf Outdated Show resolved Hide resolved
main.nf Outdated Show resolved Hide resolved
main.nf Show resolved Hide resolved
apeltzer
apeltzer reviewed Jan 14, 2019
View reviewed changes
nextflow.config Outdated Show resolved Hide resolved
apeltzer
apeltzer requested changes Jan 18, 2019
View reviewed changes
Copy link
Member

@apeltzer apeltzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor things basically :-)

conf/test.config Show resolved Hide resolved
main.nf Outdated Show resolved Hide resolved
main.nf Outdated Show resolved Hide resolved
main.nf Outdated Show resolved Hide resolved
main.nf Outdated Show resolved Hide resolved
@HadrienG HadrienG merged commit 0fa1b1e into master Jan 21, 2019
d4straub added a commit that referenced this pull request Jul 13, 2020
@d4straub
Merge pull request #5 from nf-core/dev
8992e49 
Dev
jfy133 added a commit that referenced this pull request Jan 25, 2022
@jfy133
Merge pull request #5 from nf-core/dev
013e424 
Dev
CarsonJM pushed a commit that referenced this pull request Jul 21, 2023
@PhilPalmer
Merge pull request #5 from CarsonJM/genomad
80fe071 
Modified files to use geNomad nf-core modules
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ewels ewels ewels left review comments

@apeltzer apeltzer apeltzer requested changes

Assignees
No one assigned
Labels
WIP Work in progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@HadrienG @ewels @apeltzer @maxulysse