Add nf-test to chromap/chromap #5678
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxulysse
approved these changes
May 22, 2024
|
Can you delete the old pytest tests? |
They should be deleted in my first commit! |
adamrtalbot
approved these changes
May 22, 2024
maxulysse
reviewed
May 22, 2024
maxulysse
reviewed
May 22, 2024
JoseEspinosa
approved these changes
May 22, 2024
There was a problem hiding this comment.
I think you forgot to remove the module from tests/config/pytest_modules.yml here. Please do it before merging, I won't request changes not to block the merge as I am clocking off now.
|
@bnovotny hope you don't mind, I committed to your branch to finish this PR |
Don't mind at all, thank you for finishing it!! |
tstoeriko
pushed a commit
to tstoeriko/nf-core-modules
that referenced
this pull request
May 23, 2024
* Add nf-test to chromap/chromap * Add nf-test to chromap/chromap (tags added) * Update modules/nf-core/chromap/chromap/tests/main.nf.test * Update modules/nf-core/chromap/chromap/tests/tags.yml * Update pytest_modules.yml * Update main.nf.test * Update main.nf.test.snap * Update main.nf.test * Update main.nf.test.snap --------- Co-authored-by: Maxime U Garcia <maxime.garcia@seqera.io> Co-authored-by: Maxime U Garcia <max.u.garcia@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
Closes #XXX
versions.ymlfile.labelnf-core modules test <MODULE> --profile dockernf-core modules test <MODULE> --profile singularitynf-core modules test <MODULE> --profile condanf-core subworkflows test <SUBWORKFLOW> --profile dockernf-core subworkflows test <SUBWORKFLOW> --profile singularitynf-core subworkflows test <SUBWORKFLOW> --profile conda