-
Notifications
You must be signed in to change notification settings - Fork 716
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding a QUAST module #130
Conversation
Thanks @KevinMenden . Ok, I think I have a solution that allows us to keep this repo clean from duplicating modules to deal with optional inputs. It's not ideal but possibly the best solution that allows developers to use their own parameter names e.g. instead of
If we add two more boolean variables to the What do you think? |
Okay yes, it's the best we can do right now I reckon :/ The only thing I'm a bit worried is how the Thanks @drpatelh ! Will ping you when I've changed it. |
Cool. Yup, that is exactly what I do if |
@drpatelh okay everything refactored now :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing! Thanks @KevinMenden . Few minor changes. I find it more intuitive grouping by variable type than by name.
Co-authored-by: Harshil Patel <drpatelh@users.noreply.github.com>
Co-authored-by: Harshil Patel <drpatelh@users.noreply.github.com>
Co-authored-by: Harshil Patel <drpatelh@users.noreply.github.com>
Co-authored-by: Harshil Patel <drpatelh@users.noreply.github.com>
Co-authored-by: Harshil Patel <drpatelh@users.noreply.github.com>
Co-authored-by: Harshil Patel <drpatelh@users.noreply.github.com>
Co-authored-by: Harshil Patel <drpatelh@users.noreply.github.com>
Alright thanks for the review! |
This PR adds a QUAST module.
To accommodate the two usecases of running quast with and without a reference genome, I ended up creating two modules, or "tools" for QUAST. I tried out a few things but as of now there's really no good way of dealing with optional inputs in DSL2. Until that's possibly, I think this is an adequate solution.
Let me know if you find any bugs or anything I should change :)