Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New ensemblvep/download module #2847

Merged
merged 9 commits into from
Feb 7, 2023
Merged

New ensemblvep/download module #2847

merged 9 commits into from
Feb 7, 2023

Conversation

maxulysse
Copy link
Member

  • ensemblvep -> ensemblvep/vep + add ensemblvep/download
  • update tags

PR checklist

Closes #XXX

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the module conventions in the contribution docs
  • If necessary, include test data in your PR.
  • Remove all TODO statements.
  • Emit the versions.yml file.
  • Follow the naming conventions.
  • Follow the parameters requirements.
  • Follow the input/output options guidelines.
  • Add a resource label
  • Use BioConda and BioContainers if possible to fulfil software requirements.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • PROFILE=docker pytest --tag <MODULE> --symlink --keep-workflow-wd --git-aware
    • PROFILE=singularity pytest --tag <MODULE> --symlink --keep-workflow-wd --git-aware
    • PROFILE=conda pytest --tag <MODULE> --symlink --keep-workflow-wd --git-aware

nvnieuwk
nvnieuwk approved these changes Feb 7, 2023
View reviewed changes
Copy link
Contributor

@nvnieuwk nvnieuwk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A small comment on the stub otherwise LGTM

modules/nf-core/ensemblvep/download/main.nf Outdated Show resolved Hide resolved
@maxulysse maxulysse merged commit bea3ca9 into nf-core:master Feb 7, 2023
@mirpedrol mirpedrol mentioned this pull request Feb 7, 2023
Merged
4 tasks
@maxulysse maxulysse deleted the ensemblvep branch February 22, 2023 09:46
sam-white04 pushed a commit to fulcrumgenomics/nf-core-modules that referenced this pull request Feb 27, 2023
@maxulysse
New ensemblvep/download module (nf-core#2847)
b7fd75f 
* ensemblvep -> ensemblvep/vep + add ensemblvep/download

* update tags

* lint

* fix subworkflow tag

* update exclude matrix

* proper stub
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nvnieuwk nvnieuwk nvnieuwk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maxulysse @nvnieuwk