new module: rasusa #413
new module: rasusa #413
Conversation
There was a problem hiding this comment.
Looks great @thanhleviet ! Few changes. Test weren't triggered because this file wasnt updated with the module.
Did you use nf-core modules create or manually create the module? The former would have automatically updated that file.
yes I used nf-core command. |
software/rasusa/main.nf
Outdated
|
|
||
| script: | ||
| def software = getSoftwareName(task.process) | ||
| def prefix = options.suffix ? "${meta.id}${options.suffix}_${depth_cutoff}X" : "${meta.id}_${depth_cutoff}X" |
There was a problem hiding this comment.
| def prefix = options.suffix ? "${meta.id}${options.suffix}_${depth_cutoff}X" : "${meta.id}_${depth_cutoff}X" | |
| def prefix = options.suffix ? "${meta.id}.${options.suffix}" : "${meta.id}" |
There was a problem hiding this comment.
The suffix should come in via options.suffix to keep it completely flexible for developers to name their files however they want.
There was a problem hiding this comment.
OK, how can I assign depth_cutoff to suffix in a flexible way so that we don't need to define this twice?
There was a problem hiding this comment.
Looks awesome @thanhleviet ! Almost there. Just a few little changes left.
software/rasusa/main.nf
Outdated
|
|
||
| script: | ||
| def software = getSoftwareName(task.process) | ||
| def prefix = options.suffix ? "${meta.id}${options.suffix}_${depth_cutoff}X" : "${meta.id}_${depth_cutoff}X" |
There was a problem hiding this comment.
The suffix should come in via options.suffix to keep it completely flexible for developers to name their files however they want.
software/rasusa/main.nf
Outdated
| tuple val(meta), path(reads) | ||
| val depth_cutoff | ||
| val genome_size |
There was a problem hiding this comment.
| tuple val(meta), path(reads) | |
| val depth_cutoff | |
| val genome_size | |
| tuple val(meta), path(reads) | |
| val depth_cutoff | |
| val genome_size |
PR checklist
<SOFTWARE>.version.txtfile.labelPROFILE=docker pytest --tag <MODULE> --symlink --keep-workflow-wdPROFILE=singularity pytest --tag <MODULE> --symlink --keep-workflow-wdPROFILE=conda pytest --tag <MODULE> --symlink --keep-workflow-wd