Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Small little fix to cellrangerarc main count #4839

Merged
merged 2 commits into from
Mar 7, 2024
Merged

Small little fix to cellrangerarc main count #4839

merged 2 commits into from
Mar 7, 2024

Conversation

heylf
Copy link
Contributor

@heylf heylf commented Feb 2, 2024

PR checklist

Closes #XXX

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the module conventions in the contribution docs
  • If necessary, include test data in your PR.
  • Remove all TODO statements.
  • Emit the versions.yml file.
  • Follow the naming conventions.
  • Follow the parameters requirements.
  • Follow the input/output options guidelines.
  • Add a resource label
  • Use BioConda and BioContainers if possible to fulfil software requirements.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • PROFILE=docker pytest --tag <MODULE> --symlink --keep-workflow-wd --git-aware
    • PROFILE=singularity pytest --tag <MODULE> --symlink --keep-workflow-wd --git-aware
    • PROFILE=conda pytest --tag <MODULE> --symlink --keep-workflow-wd --git-aware

mashehu
mashehu approved these changes Feb 2, 2024
View reviewed changes
modules/nf-core/cellrangerarc/count/main.nf Outdated Show resolved Hide resolved
@heylf @mashehu
Update modules/nf-core/cellrangerarc/count/main.nf
27c2932 
Co-authored-by: Matthias Hörtenhuber <mashehu@users.noreply.github.com>
@heylf
Copy link
Contributor Author

heylf commented Mar 7, 2024

@mashehu could you please merge.

@mashehu mashehu enabled auto-merge March 7, 2024 16:18
@heylf heylf mentioned this pull request Mar 7, 2024
Merged
11 tasks
@mashehu mashehu added this pull request to the merge queue Mar 7, 2024
Merged via the queue into nf-core:master with commit 18e53e2 Mar 7, 2024
10 checks passed
jch-13 pushed a commit to jch-13/modules that referenced this pull request Mar 19, 2024
@heylf @mashehu @jch-13
Small little fix to cellrangerarc main count (nf-core#4839)
6825f75 
* Small little fix to cellrangerarc main count

* Update modules/nf-core/cellrangerarc/count/main.nf

Co-authored-by: Matthias Hörtenhuber <mashehu@users.noreply.github.com>

---------

Co-authored-by: Matthias Hörtenhuber <mashehu@users.noreply.github.com>
jennylsmith pushed a commit to RSC-RP/modules that referenced this pull request Mar 20, 2024
@heylf @mashehu @jennylsmith
Small little fix to cellrangerarc main count (nf-core#4839)
67337be 
* Small little fix to cellrangerarc main count

* Update modules/nf-core/cellrangerarc/count/main.nf

Co-authored-by: Matthias Hörtenhuber <mashehu@users.noreply.github.com>

---------

Co-authored-by: Matthias Hörtenhuber <mashehu@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mashehu mashehu mashehu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@heylf @mashehu