Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 1.0.0 #85

Merged
merged 622 commits into from
Aug 26, 2024
Merged

Release 1.0.0 #85

merged 622 commits into from
Aug 26, 2024

Conversation

scwatts
Copy link
Collaborator

@scwatts scwatts commented Aug 7, 2024

This PR is for the initial release following completion of the community review. For details on the community review, please see:

Tasks

  • Rerun and complete full test suite as final sanity check
  • Organise materials for public communication
  • Update CHANGELOG.md release date

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/oncoanalyser branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Check for unexpected warnings in debug mode (nextflow run . -profile debug,test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@scwatts scwatts added this to the Release 1.0.0 milestone Aug 7, 2024
@scwatts scwatts self-assigned this Aug 7, 2024
Copy link

github-actions bot commented Aug 7, 2024

nf-core lint overall result: Passed ✅ ⚠️

Posted for pipeline commit 0648ad6

+| ✅ 177 tests passed       |+
#| ❔   5 tests were ignored |#
!| ❗  13 tests had warnings |!

❗ Test warnings:

  • files_exist - File not found: assets/multiqc_config.yml
  • nextflow_config - Config manifest.version should end in dev: 1.0.0
  • readme - README contains the placeholder zenodo.XXXXXXX. This should be replaced with the zenodo doi (after the first release).
  • pipeline_todos - TODO string in main.nf: Optionally add bibliographic entries to this list.
  • pipeline_todos - TODO string in main.nf: Only uncomment below if logic in toolCitationText/toolBibliographyText has been filled!
  • pipeline_todos - TODO string in awsfulltest.yml: You can customise AWS full pipeline tests as required
  • schema_params - Schema param panel not found from nextflow config
  • schema_params - Schema param genome_version not found from nextflow config
  • schema_params - Schema param genome_type not found from nextflow config
  • schema_params - Schema param ref_data_hmf_data_path not found from nextflow config
  • schema_params - Schema param ref_data_panel_data_path not found from nextflow config
  • schema_params - Schema param ref_data_virusbreakenddb_path not found from nextflow config
  • schema_params - Schema param ref_data_hla_slice_bed not found from nextflow config

❔ Tests ignored:

✅ Tests passed:

Run details

  • nf-core/tools version 2.14.1
  • Run at 2024-08-23 00:33:22

@scwatts scwatts marked this pull request as ready for review August 23, 2024 00:19
@scwatts scwatts requested a review from ohofmann August 23, 2024 07:03
Copy link

@ohofmann ohofmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a lot of commits. Looking forward to the initial release!

@scwatts scwatts merged commit 4227bc1 into master Aug 26, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants