Skip to content
This repository has been archived by the owner on May 6, 2024. It is now read-only.

Misspelled "search_engines" argument runs workflow without search #21

Closed
hendrikweisser opened this issue Apr 22, 2022 · 1 comment
Closed
Labels
bug Something isn't working

Comments

@hendrikweisser
Copy link

Description of the bug

Not a huge problem, but still worth fixing in my opinion: If an invalid value is passed to the "search_engines" parameter (e.g. "mgsf" instead of "msgf"), the workflow will run and "complete successfully", but no searches or subsequent steps will be performed.
Aborting with an informative error message (e.g. "Error: invalid value for parameter 'search_engines': mgsf") would be more useful in such a case.
It may be worth checking that all parameters that require specific values are validated to avoid unexpected results.

Command used and terminal output

$ nextflow run nf-core/quantms -r dev -profile docker --input ../experimental_design_mzML.tsv --database ../Human_reference_proteome_TD.fasta --search_engines mgsf --outdir results_test --labelling_type "label free sample" --acquisition_method dda
[...]
executor >  local (13)
[a6/835132] process > NFCORE_QUANTMS:QUANTMS:INPUT_CHECK:SAMPLESHEET_CHECK                                      [100%] 1 of 1 ✔
[c3/d7052e] process > NFCORE_QUANTMS:QUANTMS:CREATE_INPUT_CHANNEL:PREPROCESS_EXPDESIGN                          [100%] 1 of 1 ✔
[-        ] process > NFCORE_QUANTMS:QUANTMS:FILE_PREPARATION:THERMORAWFILEPARSER                               -
[f9/21a528] process > NFCORE_QUANTMS:QUANTMS:FILE_PREPARATION:MZMLINDEXING (20220301a_JR_SST_05)                [100%] 10 of 10 ✔
[-        ] process > NFCORE_QUANTMS:QUANTMS:TMT:ID:PSMRESCORING:EXTRACTPSMFEATURES                             -
[-        ] process > NFCORE_QUANTMS:QUANTMS:TMT:ID:PSMRESCORING:PERCOLATOR                                     -
[-        ] process > NFCORE_QUANTMS:QUANTMS:TMT:ID:PSMFDRCONTROL:IDSCORESWITCHER                               -
[-        ] process > NFCORE_QUANTMS:QUANTMS:TMT:ID:PSMFDRCONTROL:IDFILTER                                      -
[-        ] process > NFCORE_QUANTMS:QUANTMS:TMT:FEATUREMAPPER:ISOBARICANALYZER                                 -
[-        ] process > NFCORE_QUANTMS:QUANTMS:TMT:FEATUREMAPPER:IDMAPPER                                         -
[-        ] process > NFCORE_QUANTMS:QUANTMS:TMT:FILEMERGE                                                      -
[-        ] process > NFCORE_QUANTMS:QUANTMS:TMT:PROTEININFERENCE:PROTEININFERENCER                             -
[-        ] process > NFCORE_QUANTMS:QUANTMS:TMT:PROTEININFERENCE:IDFILTER                                      -
[-        ] process > NFCORE_QUANTMS:QUANTMS:TMT:PROTEINQUANT:IDCONFLICTRESOLVER                                -
[-        ] process > NFCORE_QUANTMS:QUANTMS:TMT:PROTEINQUANT:PROTEINQUANTIFIER                                 -
[-        ] process > NFCORE_QUANTMS:QUANTMS:TMT:PROTEINQUANT:MSSTATSCONVERTER                                  -
[-        ] process > NFCORE_QUANTMS:QUANTMS:LFQ:ID:PSMRESCORING:EXTRACTPSMFEATURES                             -
[-        ] process > NFCORE_QUANTMS:QUANTMS:LFQ:ID:PSMRESCORING:PERCOLATOR                                     -
[-        ] process > NFCORE_QUANTMS:QUANTMS:LFQ:ID:PSMFDRCONTROL:IDSCORESWITCHER                               -
[-        ] process > NFCORE_QUANTMS:QUANTMS:LFQ:ID:PSMFDRCONTROL:IDFILTER                                      -
[-        ] process > NFCORE_QUANTMS:QUANTMS:LFQ:PROTEOMICSLFQ                                                  -
[-        ] process > NFCORE_QUANTMS:QUANTMS:LFQ:MSSTATS                                                        -
[-        ] process > NFCORE_QUANTMS:QUANTMS:DIA:DIANNCFG                                                       -
[-        ] process > NFCORE_QUANTMS:QUANTMS:DIA:LIBRARYGENERATION                                              -
[-        ] process > NFCORE_QUANTMS:QUANTMS:DIA:DIANNSEARCH                                                    -
[-        ] process > NFCORE_QUANTMS:QUANTMS:DIA:DIANNCONVERT                                                   -
[c4/6c40ab] process > NFCORE_QUANTMS:QUANTMS:CUSTOM_DUMPSOFTWAREVERSIONS (1)                                    [100%] 1 of 1 ✔
[-        ] process > NFCORE_QUANTMS:QUANTMS:SUMMARYPIPELINE                                                    -
-[nf-core/quantms] Pipeline completed successfully-

Relevant files

No response

System information

Nextflow version: 21.10.6
nf-core/quantms revision: 1193c6e [dev]
OS: Ubuntu 20.04.4 LTS

@hendrikweisser hendrikweisser added the bug Something isn't working label Apr 22, 2022
ypriverol added a commit that referenced this issue Aug 4, 2022
jpfeuffer pushed a commit that referenced this issue Oct 18, 2022
testing with dev version of OpenMS 2.8.0
@ypriverol
Copy link
Member

This has been done.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants