-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added offline run flag and profile #29
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added some suggestions. Not sure if we should also check for any DBs that can not be run offline when the --offline
parameter is set to also trough a warning
conf/offline.config
Outdated
|
||
// Other parameters | ||
offline_run = true | ||
local_databases = true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't you need also to provide here the paths to the local DBs?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think I can. I have no prior knowledge of the file structure on the user's machine.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As discussed on slack I was referring of creating a small version of the databases for running a test using the offline
mode
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done now, see test_offline.config
ch_samplesheet_fasta.ifEmpty { | ||
fasta_input = true | ||
} | ||
if (fasta_input && params.offline_run) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we want to through a warning here instead making clear that using fasta
could have an impact on the rate limit if too many files are provided?
Co-authored-by: Jose Espinosa-Carrasco <kadomu@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! LGTM 🚀
Closes #28
offline_run
optionoffline
profileNote: the options only affect the ortholog fetching, downstream still requires network. FASTA input is not available for offline runs for now.
PR checklist
nf-core lint
).nextflow run . -profile test,docker --outdir <OUTDIR>
).