Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add gene symbols to merged output #561

Closed
grst opened this issue Feb 2, 2021 · 6 comments
Closed

Add gene symbols to merged output #561

grst opened this issue Feb 2, 2021 · 6 comments
Assignees

Comments

@grst
Copy link
Member

grst commented Feb 2, 2021

Is your feature request related to a problem? Please describe

For downstream analysis it is often useful to have the gene symbols available alongside gene ids.
Adding them later is additional effort and requires knowledge which GTF file was originally used
for the analysis.

Describe the solution you'd like

Add the gene symbols to the salmon.merged.*.tsv (and, in fact, also to the RSEM outputs).
This was already the case before #555.

As a side note:
there are .rds files (which contain the gene symbols) for gene_counts_length_scaled, gene_counts, gene_counts_scaled and transcript_counts, but not for gene_tpm, gene_tpm_scaled and gene_tpm_lengh_scaled.
Maybe this could be made consistent as well.

lpantano pushed a commit that referenced this issue Feb 5, 2021
@lpantano
Copy link
Contributor

lpantano commented Feb 5, 2021

Would you be able to run your data with this version: #564, just to make sure the output files are ok now before doing a proper PR?

Thanks!

@grst
Copy link
Member Author

grst commented Feb 5, 2021

sure, will try it on Monday!

@lpantano
Copy link
Contributor

lpantano commented Feb 6, 2021

Well, it is failing ... i forgot to change the R script since I changed the dimension of the table duh! I will fix it on Monday and let you know. Thanks!

@drpatelh
Copy link
Member

Assuming this will be closed by #564 ?

@lpantano
Copy link
Contributor

yes

@drpatelh
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants