Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3.3: Sample sheet error check false positive #705

Closed
2 tasks done
mjsteinbaugh opened this issue Sep 30, 2021 · 4 comments
Closed
2 tasks done

3.3: Sample sheet error check false positive #705

mjsteinbaugh opened this issue Sep 30, 2021 · 4 comments
Labels
bug Something isn't working

Comments

@mjsteinbaugh
Copy link

mjsteinbaugh commented Sep 30, 2021

Check Documentation

I have checked the following places for your error:

Description of the bug

Seeing a weird false positive error message for the samplesheet.csv checker.

ERROR: Please check samplesheet header -> sample,fastq_1,fastq_2,strandedness != sample,fastq_1,fastq_2,strandedness

Steps to reproduce

nextflow run 'nf-core/rnaseq' \
    -r '3.3' \
    -profile 'docker' \
    --aligner 'star_salmon' \
    --genome 'GRCh38' \
    --input 'samplesheet.csv'

Expected behaviour

These columns match the current recommendations in the documentation.

@mjsteinbaugh mjsteinbaugh added the bug Something isn't working label Sep 30, 2021
@mjsteinbaugh
Copy link
Author

Figured this out, bad CSV conversion from Excel. Need to resave in UTF-8 (no BOM), Unix LF instead of Windows CRLF. The error message could be improved to detect this.

@drpatelh
Copy link
Member

drpatelh commented Oct 3, 2021

Hi @mjsteinbaugh ! Thanks for reporting. This has come up a few times now but it's difficult to test and reproduce. Be great if you are able to reproduce and upload the samplesheet here. Failing that I can try to push a tentative fix to see if it resolves the issue for you locally.

@mjsteinbaugh
Copy link
Author

Sure thing I'll make a couple of minimal examples that fail and will post them here.

@mjsteinbaugh
Copy link
Author

@drpatelh Saw your post on Slack, I'll follow up when I have some free time

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants