Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add slash to outdir for cloud tests to fix Azure validation… #1157

Merged
merged 2 commits into from
Jan 5, 2024
Merged

Add slash to outdir for cloud tests to fix Azure validation… #1157

merged 2 commits into from
Jan 5, 2024

Conversation

drpatelh
Copy link
Member

@drpatelh drpatelh commented Jan 5, 2024

To fix failing Azure tests as you can see here

The workflow execution failed to start. Exit status: 1

Pulling nf-core/rnaseq ...
 downloaded from https://github.com/nf-core/rnaseq.git
Launching `https://github.com/nf-core/rnaseq` [azure_rnaseq_small] DSL2 - revision: a10f41afa2 [master]
Downloading plugin nf-validation@1.1.3
ERROR ~ ERROR: Validation of pipeline parameters failed!

 -- Check 'nf-41SRHZWS3jEMPX.log' file for details
�[0;31mThe following invalid input values have been detected:

* --outdir: 'az://work/rnaseq/results-test-a10f41afa204538d5dcc89a5910c299d68f94f41' is not a directory, but a file (az://work/rnaseq/results-test-a10f41afa204538d5dcc89a5910c299d68f94f41)
�[0m

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 5, 2024 •
edited
Loading

nf-core lint overall result: Passed ✅ ⚠️

Posted for pipeline commit 5899b4c

+| ✅ 145 tests passed       |+
#| ❔   6 tests were ignored |#
!| ❗   5 tests had warnings |!

❗ Test warnings:

  • files_exist - File not found: .github/workflows/awstest.yml
  • files_exist - File not found: .github/workflows/awsfulltest.yml
  • nextflow_config - Config manifest.version should end in dev: 3.14.0
  • pipeline_todos - TODO string in methods_description_template.yml: #Update the HTML below to your preferred methods description, e.g. add publication citation for this pipeline
  • pipeline_todos - TODO string in WorkflowRnaseq.groovy: Optionally add in-text citation tools to this list.

❔ Tests ignored:

  • files_unchanged - File ignored due to lint config: assets/email_template.html
  • files_unchanged - File ignored due to lint config: assets/email_template.txt
  • files_unchanged - File ignored due to lint config: lib/NfcoreTemplate.groovy
  • files_unchanged - File ignored due to lint config: .gitignore or .prettierignore or pyproject.toml
  • actions_awstest - 'awstest.yml' workflow not found: /home/runner/work/rnaseq/rnaseq/.github/workflows/awstest.yml
  • multiqc_config - multiqc_config

✅ Tests passed:

Run details

  • nf-core/tools version 2.11.1
  • Run at 2024-01-05 10:40:25

pinin4fjords
pinin4fjords approved these changes Jan 5, 2024
View reviewed changes
Copy link
Member

@pinin4fjords pinin4fjords left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@drpatelh drpatelh merged commit 0e79758 into nf-core:dev Jan 5, 2024
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pinin4fjords pinin4fjords pinin4fjords approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@drpatelh @pinin4fjords