Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Sentieon_BQSR is not skipped when dbsnp and indel files are not provided #391

Closed
4 tasks
grendon opened this issue Jun 17, 2021 · 3 comments
Closed
4 tasks
Assignees
Labels
bug Something isn't working sentieon
Milestone

Comments

@grendon
Copy link

grendon commented Jun 17, 2021

Check Documentation

I have checked the following places for your error:

Description of the bug

I want the sarek pipeline to SKIP BQRS because I don't have dbsnp and indels for my rice genome. But the pipeline tries to run Sentieon_BQSR anyway and fails. What am I doing wrong?

Steps to reproduce

Steps to reproduce the behaviour:

  1. Command line:

nextflow run ./sarek/ -c mapping.conf -profile uiuc_hpcbio --custom_config_base /home/groups/hpcbio/projects/meksem/2021-June-Rice/results/20210612-11-Samples/configs -resume -qs 4 -with-report -with-trace

  1. See error:
Meksem_8.deduped.bam`         --algo QualCal         -k input.3         Meksem_8.recal.table

  sentieon driver         -t 24         -r GCF_001433935.1_IRGSP-1.0_genomic.fna         -i Meksem_8.deduped.bam         -q Meksem_8.recal.table         --algo QualCal         -k input.3         Meksem_8.table.post         --algo ReadWriter Meksem_8.recal.bam

  sentieon driver         -t 24         --algo QualCal         --plot         --before Meksem_8.recal.table         --after Meksem_8.table.post         Meksem_8_recal_result.csv

Command exit status:
  1

Command output:
  (empty)

Command error:
  cmdline: /home/apps/software/sentieon/201911/libexec/driver -t 24 -r GCF_001433935.1_IRGSP-1.0_genomic.fna -i Meksem_8.deduped.bam --algo QualCal -k input.3 Meksem_8.recal.table
  This software is licensed to dslater@illinois.edu by Sentieon Inc.
  Error: Unrecognized format for vcf file input.3

Work dir:
  /home/groups/hpcbio/projects/meksem/2021-June-Rice/results/20210612-11-Samples/work/e0/62a1cb946b94d27021fa2333f8cdc5

Tip: view the complete command output by changing to the process work dir and entering the command `cat .command.out`

Expected behaviour

I expected the pipieline to skip the Sentieon_BQSR process where it failed

Log files

Have you provided the following extra information/files:

  • The command used to run the pipeline
  • The .nextflow.log file

nextflow.log
samples.tsv.txt
mapping.conf.txt

System

  • Hardware:
  • Executor:
  • OS:
  • Version

Nextflow Installation

  • Version:

nextflow/20.11.0-edge-Java_1.8.0_152

Container engine

  • Engine: singularity
  • version: 3.4.1
  • Image tag: nf-core-sarek-2.7

Additional context

Processing a non-human genome that does not have dbsnp or indel files

@grendon grendon added the bug Something isn't working label Jun 17, 2021
@maxulysse
Copy link
Member

Hi @grendon

First congratulations, we don't have many people running Sentieon with sarek.
I'm always happy to see other people do it.
Unfortunately, the small number of people using this feature should explain why it's failing for you at the moment.
I added Sentieon for clinical purpose, so I haven't taken into account the possibility of not having dbsnp and indels.
But I'll make sure to correct that for DSL2.
We currently refactoring sarek for the 3.0 release which will be more modular, and the plan is to fully use this Nextflow functionality with dedicated subworkflows.

@maxulysse maxulysse added this to the 3.0 milestone Jun 18, 2021
@FriederikeHanssen FriederikeHanssen modified the milestones: 3.0, 3.1 Jun 10, 2022
@maxulysse maxulysse modified the milestones: 3.1, 3.2 Nov 23, 2022
@maxulysse maxulysse modified the milestones: 3.2, 3.3 Jun 22, 2023
@FriederikeHanssen
Copy link
Contributor

@asp8200 How is this handeled currently? Is this issue still relevant?

@asp8200
Copy link
Contributor

asp8200 commented Aug 15, 2023

This is issue no longer relevant as we don't have Sentieon's BQSR function implemented in Sarek, and we don't plan to implement it in Sarek.

https://github.com/nf-core/sarek/blob/dev/docs/usage.md#qualcal-bqsr

@asp8200 asp8200 closed this as completed Aug 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working sentieon
Projects
None yet
Development

No branches or pull requests

4 participants