Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass target-bed-file to bcftools/stats? #699

Open
asp8200 opened this issue Aug 1, 2022 · 0 comments
Open

Pass target-bed-file to bcftools/stats? #699

asp8200 opened this issue Aug 1, 2022 · 0 comments
Labels
enhancement New feature or request

Comments

@asp8200
Copy link
Contributor

asp8200 commented Aug 1, 2022

Description of feature

Do we want to pass a target-bed-file to the module BCFTOOLS_STATS in subworkflows/nf-core/vcf_qc.nf? By supplying a target-bed-file to BCFTOOLS_STATS, we (supposedly) get some nice depth-plot.

With the target-bed-file but without the tbi-file for the vcf-input-file, BCFTOOLS_STATS throws the following error:

nextflow run main.nf -profile test,tools_tumoronly,singularity --tools manta

resulted in the following error:

  Process `NFCORE_SAREK:SAREK:VCF_QC:BCFTOOLS_STATS (sample2)` terminated with an error exit status (255)

Command executed:

  bcftools stats \
       \
      --regions-file multi_intervals.bed \
      sample2.manta.tumor_sv.vcf.gz > sample2.manta.tumor_sv.bcftools_stats.txt

  cat <<-END_VERSIONS > versions.yml
  "NFCORE_SAREK:SAREK:VCF_QC:BCFTOOLS_STATS":
      bcftools: $(bcftools --version 2>&1 | head -n1 | sed 's/^.*bcftools //; s/ .*$//')
  END_VERSIONS

Command exit status:
  255

Command output:
  (empty)

Command error:
  [E::idx_find_and_load] Could not retrieve index file for 'sample2.manta.tumor_sv.vcf.gz'
  Failed to read from sample2.manta.tumor_sv.vcf.gz: could not load index

Work dir:
  /home/aspe/dev/fork_sarek/work/9b/0c3268ad4e17ee489871c6849292ff

The advantage of passing the target-bed-file to bcftools-stats, would be that then we get a depth-plot for wes-samples.

@SusiJo wrote the following on Slack explaining the problem in detail: "My problem was that I do not have any real WES data to test this properly, only the testdata itself. If the depth plot is really not displayed correctly in the multiqc report for real data without a target-bed file, then i would say it’s worth the effort. An empty plot in a multiqc is really weird and confusing. There are some modules in multiqc that state explicitly when there’s nothing to plot (like a warning). It would be nice to have sth like that for bcftools as well rather than showing an empty plot.
For some testdata cases there were these empty plots, but i assumed there would be depths to plot for real data.
So before changing the module upstream and a lot of stuff in sarek with these tbiand vcf files i’d like to know if anyone who ran with real WES data has seen empty depth plots.. or if that’s really just a problem with the testdata.. If it’s just a testdata issue, it might even make sense to remove the target_bed from the bcftools module again. "

@asp8200 asp8200 added the enhancement New feature or request label Aug 1, 2022
@maxulysse maxulysse added this to the 3.3 milestone Feb 21, 2023
@maxulysse maxulysse modified the milestones: 3.3, 3.4, 3.5 Feb 8, 2024
@FriederikeHanssen FriederikeHanssen removed this from the 3.5 milestone Aug 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Not planned for this release
Development

No branches or pull requests

3 participants