Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Customize Preprocessing based on each tool #830

Open
berguner opened this issue Nov 11, 2022 · 4 comments
Open

Customize Preprocessing based on each tool #830

berguner opened this issue Nov 11, 2022 · 4 comments
Labels
enhancement New feature or request

Comments

@berguner
Copy link
Contributor

Description of feature

Hi,
It seems like the CNVkit workflow uses cram_recalibrated files as input here:

workflow RUN_CNVKIT {
take:
cram_recalibrated // channel: [mandatory] cram
fasta // channel: [mandatory] fasta
. As far as I remember, recalibrated files of WES or panel samples don't contain off-target reads because base recalibration is applied over the intervals only. It would be better using CRAM files containing all the reads (cram_markduplicates ?) for CNVkit analysis for utilizing off-target reads. This is especially important for custom panels where there are fewer target regions compared to WES.

@berguner berguner added the enhancement New feature or request label Nov 11, 2022
@FriederikeHanssen
Copy link
Contributor

Hi! You can always achieve this by setting the parrameter --skip_tools baserecalibrator . I will add some docs on this.

@berguner
Copy link
Contributor Author

But wouldn't that make the pipeline skip recalibration for SNV/indel calling also? I usually run the pipeline with --tools "mutect2,vep,cnvkit".

@FriederikeHanssen
Copy link
Contributor

FriederikeHanssen commented Nov 11, 2022

Yes, currently it is only possible to do one "type" of pre-processing.

I would transfer this to a bigger feature requests:

For scenarios such as above, it would be nice to allow different types of preprocessing. This would require tool based preprocessing steps, that ideally would still be customizable.

Such as:

md+ bqsr + haplotypecaller
no md + bqsr + deepvariant
md + no bqsr + cnvkit

(examples are completely made up)

This would llikely entail quite a massive change in how we manage data flow at the moment

@FriederikeHanssen FriederikeHanssen changed the title Utilize off-target reads in CNVkit analysis of WES samples Customize Preprocessing based on each tool Nov 11, 2022
@FriederikeHanssen
Copy link
Contributor

Other current options as a work around:

Utilize the --step functions to run the one tool that needs different preprocessing on the respective csv file that is available in results/csv to avoid duplicate mapping for example and save time & resources

@maxulysse maxulysse added this to the 3.2 milestone Feb 21, 2023
@maxulysse maxulysse modified the milestones: 3.2, 3.3 Jun 22, 2023
@maxulysse maxulysse modified the milestones: 3.3, 3.4, 3.5 Feb 8, 2024
@FriederikeHanssen FriederikeHanssen removed this from the 3.5 milestone Aug 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants