Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare release 2.7.1 #374

Merged
merged 90 commits into from
Jun 14, 2021
Merged

Prepare release 2.7.1 #374

merged 90 commits into from
Jun 14, 2021

Conversation

maxulysse
Copy link
Member

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
    • If you've added a new tool - add to the software_versions process and a regex to scrape_software_versions.py
    • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
    • If necessary, also make a PR on the nf-core/sarek branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint .).
  • Ensure the test suite passes (nextflow run . -profile test,docker).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

maxulysse and others added 30 commits January 26, 2021 14:44
Retry tasks with exit code 247 for added memory
Tumor-only mode for Mutect2 and MSIsensor
@maxulysse maxulysse requested a review from a team May 27, 2021 08:07
Copy link
Contributor

@FriederikeHanssen FriederikeHanssen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good. I think some things ar emissing fom the Changelog. With regards to #378 Do you still want more tests before releasing?

@maxulysse
Copy link
Member Author

Looks pretty good.

<3

I think some things are missing from the Changelog.

I did not pay attention to CHANGELOG lately, I'll make a PR for that.

With regards to #378 Do you still want more tests before releasing?

Yeah, but not specifically for #378 only I think @ggabernet was having issues (#380) which I think are now fixed in this version.

@FriederikeHanssen
Copy link
Contributor

I tried launching the pipeline with tower on our cluster and the new launch interface. for the field Email I get:
Screenshot 2021-05-27 at 11 13 03

@maxulysse
Copy link
Member Author

I tried launching the pipeline with tower on our cluster and the new launch interface. for the field Email I get: Screenshot 2021-05-27 at 11 13 03

I have no issue on the command line with:

nextflow run . -profile docker,test --email me@me.com

Any idea @nf-core/core

@maxulysse
Copy link
Member Author

Since this release is still DSL1, I wanted to put msisensor-pro in the main container, as it's usual to do.
But major Conda conflicts prevents me to do so.
So @nf-core/core @nf-core/sarek what do you think we should do?
Keep msisensor-pro in a separate container as we're doing now, and forget about about and go on more adventure with DSL2 ?

@jfnavarro
Copy link
Contributor

Since this release is still DSL1, I wanted to put msisensor-pro in the main container, as it's usual to do.
But major Conda conflicts prevents me to do so.
So @nf-core/core @nf-core/sarek what do you think we should do?
Keep msisensor-pro in a separate container as we're doing now, and forget about about and go on more adventure with DSL2 ?

Doesn't seem like you have much of a choice, do you?

@maxulysse
Copy link
Member Author

Doesn't seem like you have much of a choice, do you?

Yeah, it seems like so

@maxulysse
Copy link
Member Author

@nf-core/sarek Can I get approvals so that I can release (I can do it today, tomorrow or Thursday, but not Friday ;-))

Copy link
Contributor

@FriederikeHanssen FriederikeHanssen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 🎉 , pending the CI tests passing

@maxulysse maxulysse requested review from a team June 11, 2021 09:55
Copy link
Contributor

@jfnavarro jfnavarro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They look good to me!

@maxulysse maxulysse merged commit 68b9930 into nf-core:master Jun 14, 2021
@maxulysse maxulysse deleted the dev_2.7.1 branch August 4, 2021 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants