Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JSON Schema + latest 1.13.1 template #47

Merged
merged 38 commits into from
Mar 23, 2021
Merged

JSON Schema + latest 1.13.1 template #47

merged 38 commits into from
Mar 23, 2021

Conversation

sk-sahu
Copy link
Member

@sk-sahu sk-sahu commented Mar 22, 2021

Updates the json schema

PR checklist

  • This comment contains a description of changes (with reason)
  • Make sure your code lints (nf-core lint .).

@github-actions
Copy link

Hi @sk-sahu,

It looks like this pull-request is has been made against the nf-core/scrnaseq master branch.
The master branch on nf-core repositories should always contain code from the latest release.
Because of this, PRs to master are only allowed if they come from the nf-core/scrnaseq dev branch.

You do not need to close this PR, you can change the target branch to dev by clicking the "Edit" button at the top of this page.

Thanks again for your contribution!

@sk-sahu sk-sahu changed the base branch from master to dev March 22, 2021 12:21
@sk-sahu sk-sahu linked an issue Mar 22, 2021 that may be closed by this pull request
@sk-sahu sk-sahu requested a review from apeltzer March 22, 2021 13:09
@sk-sahu sk-sahu marked this pull request as ready for review March 22, 2021 13:09
@apeltzer apeltzer changed the title Updates json schema JSON Schema + latest 1.13.1 template Mar 22, 2021
@apeltzer
Copy link
Member

Would be great to get some reviews in here ....

.github/workflows/ci.yml Outdated Show resolved Hide resolved
Copy link
Member

@ggabernet ggabernet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, just a couple of minor comments and maybe that the Nextflow version should be bumped to 20.10.0 as otherwise there was a problem with the $projectDir variable.

.github/workflows/ci.yml Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
docs/usage.md Outdated Show resolved Hide resolved
docs/usage.md Outdated Show resolved Hide resolved
nextflow.config Outdated Show resolved Hide resolved
@sk-sahu
Copy link
Member Author

sk-sahu commented Mar 22, 2021

Sure! On it ⌨️

@sk-sahu sk-sahu requested a review from ggabernet March 22, 2021 19:22
@apeltzer
Copy link
Member

Added a tiny bit to the environment.yml to make sure the salmon bit is running through now prperly :-)

@sk-sahu
Copy link
Member Author

sk-sahu commented Mar 23, 2021

@apeltzer I think after changing the environment. It fails with pandoc-citeproc is not available!. I suppose u fixed it already

Loading required package: alevinQC
  Registered S3 method overwritten by 'GGally':
    method from   
    +.gg   ggplot2
  Loading required package: tximport
  Error in .checkPandoc(ignorePandoc) : pandoc-citeproc is not available!
  Calls: alevinQCReport -> .checkPandoc
  Execution halted

@apeltzer
Copy link
Member

I wanted to - unfortunately this is a bit provlematic now:

The previous tests were failing because of a known isssue with tbb, which needs to be pinned.

https://github.com/nf-core/scrnaseq/runs/2169179376

Now after I added this, we have a different issue, because pandoc-citeproc fails. I fear we have to update the entire environment once more now ...?

@sk-sahu
Copy link
Member Author

sk-sahu commented Mar 23, 2021

Yeah that's a good idea. Let me update and fix the entire environment

Copy link
Member

@ggabernet ggabernet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's see if we can fix the tests with this @sk-sahu

environment.yml Outdated Show resolved Hide resolved
Co-authored-by: Gisela Gabernet <gisela.gabernet@gmail.com>
Copy link
Member

@ggabernet ggabernet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! If the tests pass then from my side ready to go 😄

@apeltzer apeltzer merged commit 13b7b90 into dev Mar 23, 2021
@apeltzer apeltzer deleted the fix-json-schema branch March 23, 2021 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SCRNASEQ: Convert params docs to JSON Schema documentation
4 participants