-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JSON Schema + latest 1.13.1 template #47
Conversation
Hi @sk-sahu, It looks like this pull-request is has been made against the nf-core/scrnaseq You do not need to close this PR, you can change the target branch to Thanks again for your contribution! |
…nto fix-json-schema
Would be great to get some reviews in here .... |
Co-authored-by: Gisela Gabernet <gisela.gabernet@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, just a couple of minor comments and maybe that the Nextflow version should be bumped to 20.10.0
as otherwise there was a problem with the $projectDir
variable.
Sure! On it ⌨️ |
Co-authored-by: Gisela Gabernet <gisela.gabernet@gmail.com>
…into fix-json-schema
…into fix-json-schema
Co-authored-by: Gisela Gabernet <gisela.gabernet@gmail.com>
…into fix-json-schema
Added a tiny bit to the environment.yml to make sure the salmon bit is running through now prperly :-) |
@apeltzer I think after changing the environment. It fails with
|
I wanted to - unfortunately this is a bit provlematic now: The previous tests were failing because of a known isssue with tbb, which needs to be pinned. https://github.com/nf-core/scrnaseq/runs/2169179376 Now after I added this, we have a different issue, because pandoc-citeproc fails. I fear we have to update the entire environment once more now ...? |
Yeah that's a good idea. Let me update and fix the entire environment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's see if we can fix the tests with this @sk-sahu
Co-authored-by: Gisela Gabernet <gisela.gabernet@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! If the tests pass then from my side ready to go 😄
Updates the json schema
PR checklist
nf-core lint .
).