Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Differentialabundance match samples with matrix #726

Merged
merged 2 commits into from
Jan 10, 2023
Merged

Differentialabundance match samples with matrix #726

merged 2 commits into from
Jan 10, 2023

Conversation

pinin4fjords
Copy link
Member

@pinin4fjords pinin4fjords commented Jan 9, 2023 •
edited
Loading

This PR fixes the test data for the differentialabundance workflow:

  • Suffix removed from matrix columns such that they can be related to the sample sheet
  • Variable in contrasts file fixed to actually match what's in the sample sheet

@pinin4fjords pinin4fjords marked this pull request as draft January 9, 2023 12:07
@pinin4fjords pinin4fjords mentioned this pull request Jan 9, 2023
Closed
@pinin4fjords pinin4fjords changed the base branch from master to differentialabundance January 9, 2023 12:10
@pinin4fjords pinin4fjords marked this pull request as ready for review January 9, 2023 16:40
erikrikarddaniel
erikrikarddaniel approved these changes Jan 9, 2023
View reviewed changes
Copy link
Member

@erikrikarddaniel erikrikarddaniel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@pinin4fjords
Copy link
Member Author

Thanks @erikrikarddaniel !

@pinin4fjords pinin4fjords merged commit e856e1a into nf-core:differentialabundance Jan 10, 2023
@pinin4fjords pinin4fjords deleted the differentialabundance_match_samples_with_matrix branch January 10, 2023 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erikrikarddaniel erikrikarddaniel erikrikarddaniel approved these changes

@WackerO WackerO Awaiting requested review from WackerO

Assignees
No one assigned
Labels
Ready to review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pinin4fjords @erikrikarddaniel