Use a context to temporarily change the working directory #1819
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## dev #1819 +/- ##
=======================================
Coverage 69.25% 69.25%
=======================================
Files 59 59
Lines 7148 7148
=======================================
Hits 4950 4950
Misses 2198 2198 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
fabianegli
changed the title
|
Tests are still missing. |
fabianegli
deleted the
use-context-when-changing-working-directory-in-tests
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using contexts is safer because this way the working directory reset happens even if something unexpected happens between setting and resetting the working directory.
PR checklist
CHANGELOG.mdis updateddocsis updated