-
Notifications
You must be signed in to change notification settings - Fork 190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lint check for params.enable_conda #2213
Conversation
This PR is against the
|
Codecov Report
@@ Coverage Diff @@
## dev #2213 +/- ##
==========================================
+ Coverage 72.97% 73.31% +0.34%
==========================================
Files 78 78
Lines 8380 8384 +4
==========================================
+ Hits 6115 6147 +32
+ Misses 2265 2237 -28
... and 3 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
looks like one of the tests is failing for API rate limit reasons:
So we'll have to just retry later! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good :) Just some small comments. Let's see if the test passes. If you want, you can also add a check on the pipeline linting.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you :) Left one last comment to address, but after that looks good to me
@nf-core-bot fix linting |
Addresses #2187
usage of params.enable_conda has been deprecated. Currently it is a fail condition from the pipeline linter which only checks the config file but the module linter does not.
PR checklist
CHANGELOG.md
is updateddocs
is updatedTests were updated to catch new failures.