Make nf-core modules lint
use new config file
#2221
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously
nf-core modules lint
would use a weird mixture of.nf-core-lint.yml
(deprecated) and.nf-core.yml
; I believe this PR removes all references to the former, except for the code innf_core/utils.py
that prints a warning if only the deprecated file is present.For example, running
nf-core modules lint fastqc
on a freshly-created repo with thefastqc
module shows a warning about fastqc being out of date, even with the following.nf-core.yml
:(if you instead put that lint config in
.nf-core-lint.yml
, you get... a weird crash "AttributeError: 'NFCoreModule' object has no attribute 'process_name'", but you do also get "INFO Ignoring lint test: main_nf".)With this PR, the deprecated config file is ignored (like the rest of the lint commands), and you can only ignore the lint/cause the crash by including the lint config in
.nf-core.yml
.I'm not sure how to write a test for this – if it's worth doing so I can give it a go (I guess some relevant existing tests are probably in
tests/modules/lint.py
?)Fixes #2212
PR checklist
CHANGELOG.md
is updated