-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix incorrect assertions for called_with on mocks #2891
Conversation
…ing mocks before 3.12. Broken in 3.12.
We need to resolve the issue with the I cannot for the life of me figure out what the correct way to patch the method call of the pipeline Schema object is. I think perhaps there is an issue with the fact the class is imported inside the cli function? |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files☔ View full report in Codecov by Sentry. |
So is this good to merge now? It will make a lot of other PRs stop failing! |
I guess so😄 |
Closes #2890
fix: assertions for called_with/called_once_with were silently returning mocks before 3.12. Broken in 3.12.
PR checklist
CHANGELOG.md
is updateddocs
is updated