Fix linting fail on nfcore_external_java_deps if nf_schema is used #2976
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dev -> Master for 2.14.0
dev -> master for 2.14.1
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files☔ View full report in Codecov by Sentry. |
|
@nf-core-bot changelog |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed a bug where linting failed in pipelines using
nf_schemainstead ofnf_validation.Conditional file linting now accepts a list of parameters instead of a single one. The parameters are or-gated, i.e. a single one is sufficient to mark the parameter as present (and thus expect the file to not exist).
Please verify test coverage, as I am not familiar with the coding practices in
tools.PR checklist
CHANGELOG.mdis updateddocsis updated