Update js docs #347
Merged
Update js docs #347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix "undefined" in column name by change the property into a function. After the change the column name is correct (Input [Source Name]).
Update EXAMPLE_CreateAssayFile.js
HLWeil
reviewed
Apr 12, 2024
| @@ -6,21 +6,6 @@ | |||
|
|
|||
| // Import ARCtrl | |||
| import * as arctrl from "@nfdi4plants/arctrl" | |||
| // Alternative import | |||
There was a problem hiding this comment.
Sure we should kick this out? This was actually meant as an alternative, not some leftover code
There was a problem hiding this comment.
this is very basic js syntax knowledge, not sure if we should keep and maintain it
HLWeil
approved these changes
Apr 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.