Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove tidyverse #23

Merged
merged 2 commits into from
Feb 16, 2023
Merged

remove tidyverse #23

merged 2 commits into from
Feb 16, 2023

Conversation

guga31bb
Copy link
Member

No description provided.

@guga31bb guga31bb linked an issue Feb 15, 2023 that may be closed by this pull request
@guga31bb
Copy link
Member Author

Seems like everything runs fine without tidyverse? I have no idea why it was in Suggests but probably me not knowing what I was doing

@mrcaseb
Copy link
Member

mrcaseb commented Feb 16, 2023

The current check workflow does not run pkgdown, i.e. the vignettes/articles. I assume those would break.

@mrcaseb
Copy link
Member

mrcaseb commented Feb 16, 2023

library(nfl4th)
library(tidyverse)
library(ggplot2)
library(ggtext)
library(DescTools)
library(ggthemes)
library(gt)
library(magick)
library(cowplot)
library(nflplotR)
library(patchwork)

I would double check if all these libraries are actually necessary and maybe remove some of them.

Alternatively put tidyverse here:

install.packages(c("pkgdown", "ggtext", "DescTools", "ggthemes", "magick", "cowplot", "ggpmisc", "teamcolors", "patchwork"), type = "binary")

@guga31bb guga31bb merged commit e322d4e into master Feb 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Take tidyverse out of Suggests
2 participants