Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add player name mapping to live in nflreadr #145

Merged
merged 5 commits into from
Sep 14, 2022
Merged

add player name mapping to live in nflreadr #145

merged 5 commits into from
Sep 14, 2022

Conversation

tanho63
Copy link
Member

@tanho63 tanho63 commented Sep 13, 2022

Resolves #141, resolves #136

Moves player mapping to live in nflreadr and also refactors bug on suffix squish

Copy link
Member

@mrcaseb mrcaseb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@tanho63 tanho63 merged commit 06f3c9d into main Sep 14, 2022
@tanho63 tanho63 deleted the playernames branch September 14, 2022 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move name cleaning dictionary from ffscrapr to nflreadr, add new names Name Cleaning not working as intended
2 participants