Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding in missing fields to dictionary_snap_counts and dictionary_schedules. #93

Closed
wants to merge 20 commits into from
Closed

Adding in missing fields to dictionary_snap_counts and dictionary_schedules. #93

wants to merge 20 commits into from

Conversation

pranavrajaram
Copy link
Contributor

No description provided.

pranavrajaram and others added 20 commits December 30, 2021 16:48
@pranavrajaram
adding in dictionary_espn_qbr stuff
2ff5f8b
@pranavrajaram
Merge branch 'main' of https://github.com/pranavrajaram/nflreadr
79da8b9
@pranavrajaram
updated csv
31c45c3
@pranavrajaram
updating csv for real
e964fe8
@pranavrajaram
final edits
aad5b1e
@pranavrajaram
adding in DT table idk why i forgot
31d2675
@pranavrajaram
fixed typo and ran devtools::document()
5b5c5d5
@pranavrajaram
adding in dictionary_combine stuff
0d900dd
@pranavrajaram
getting rid of DT table on dictionary_combine
bbdd132
@pranavrajaram
adding in dictionary_injuries and fixing some combine stuff
f13652f
@pranavrajaram
adding in dictionary_depth_charts
776b7ef
@pranavrajaram
adding in dictionary_trades and fixing dictionary_depth_charts
9f059a3
@tanho63
Merge branch 'main' into main
edb73d1
@pranavrajaram
fixing apostrophes
04d99b3
@pranavrajaram
Merge branch 'main' of https://github.com/pranavrajaram/nflreadr
db47730
@pranavrajaram
Update DESCRIPTION
99fd971
@pranavrajaram
Update NEWS.md
f3849e3
@pranavrajaram
Update NEWS.md
c4fa279
@pranavrajaram
adding missing fields to dictionary_schedule and dictionary_snap_counts
8413781
@pranavrajaram
Merge branch 'main' of https://github.com/pranavrajaram/nflreadr
08f7a8c
@tanho63
Copy link
Member

tanho63 commented Mar 19, 2022

hmm this is based off of the wrong branch, it seems. I would probably save the new CSVs, delete your entire repository, and make sure to branch off from upstream before adding back the CSVs

@tanho63
Copy link
Member

tanho63 commented Mar 19, 2022 •
edited
Loading

Probably easiest instructions:

  • save the csvs to a temporary location
  • delete your entire fork on GitHub
  • usethis::create_from_github("nflverse/nflreadr", fork = TRUE) will automate repo setup including forking
  • usethis::pr_init("dictionary-updates") will automate setting up a branch for your changes
  • add the csvs back and commit
  • usethis::pr_push() to push to GitHub
  • Then re-do a PR

https://usethis.r-lib.org/articles/pr-functions.html

@pranavrajaram
Copy link
Contributor Author

whoops don't know why that happened. i'll try to fix it, thanks!

@tanho63
Copy link
Member

tanho63 commented Mar 19, 2022

No worries! Lemme know if you get stuck

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pranavrajaram @tanho63