This repository was archived by the owner on May 29, 2023. It is now read-only.
feat(SpeechSynthesis): add new module #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarsiBarsi
approved these changes
Oct 27, 2020
# Conflicts: # .github/CODEOWNERS # .github/ISSUE_TEMPLATE/bug_report.md # .github/ISSUE_TEMPLATE/feature_request.md
MarsiBarsi
reviewed
Dec 18, 2020
angular.json
Outdated
| "styles": ["projects/demo/src/styles.css"], | ||
| "styles": [ | ||
| "node_modules/@taiga-ui/core/styles/taiga-ui-global.less", | ||
| "node_modules/@taiga-ui/core/styles/taiga-ui-local.less", |
There was a problem hiding this comment.
зачем локальные в глобальные пихаешь? тогда везде юзать миксины можно что ли?
There was a problem hiding this comment.
Наверное уже можно не пихать. Баг был, что в теме юзался миксин
projects/speech/src/utils/is-said.ts
Outdated
| @@ -0,0 +1,11 @@ | |||
| export function isSaid(phrase: string): (results: SpeechRecognitionResult[]) => boolean { | |||
| const parsed = phrase.toLowerCase().trim(); | |||
There was a problem hiding this comment.
nit: не очень parsed... понятнее может даже будет с phrase = phrase.toLowerCase().trim();
| export class SpeechRecognitionService extends Observable<SpeechRecognitionResult[]> { | ||
| constructor( | ||
| @Inject(SPEECH_RECOGNITION) classRef: Type<SpeechRecognition> | null, | ||
| @Optional() @Inject(LOCALE_ID) lang: string | null = '', |
There was a problem hiding this comment.
о, локаль опшинал? не знал...
There was a problem hiding this comment.
Да, вроде. Чекну.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.