Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add clear(), push(), pop() manipulations to the Settings and Settingsjs objects #5332

Merged
merged 3 commits into from
Apr 22, 2022
Merged

Add clear(), push(), pop() manipulations to the Settings and Settingsjs objects #5332

merged 3 commits into from
Apr 22, 2022

Conversation

mschicker
Copy link
Contributor

This is mostly to facilitate unit testing, but could be useful in other circumstances as well.

Fixes #5308

bmarchant
bmarchant approved these changes Apr 21, 2022
View reviewed changes
Copy link
Contributor

@bmarchant bmarchant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@mschicker mschicker self-assigned this Apr 22, 2022
@mschicker mschicker merged commit 26bfd66 into master Apr 22, 2022
@mschicker mschicker deleted the settingsjs_clear_5308 branch April 22, 2022 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bmarchant bmarchant bmarchant approved these changes

Assignees

@mschicker mschicker

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add a .clear() function to the Settingsjs object
2 participants
@mschicker @bmarchant