create test folder with parent id of the default root folder id zero #5689
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The 'root' folder gets created in this liquibase changelog https://github.com/ngageoint/hootenanny/blob/master/hoot-services/src/main/resources/db/changelogs/022-FolderMapMappings.xml#L18-L34 so I think it should always be available for these tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I encountered a broken UI after running core tests that inserted folder with a null parent_id. I may still add some code to the UI to assume this state as the root (id=0) folder as parent.
But investigating which tests were inserting folders with a null parent_id (updated to zero in this PR) led me to this #4461.
So wondering why we didn't just do this update back then instead of all the special null handling we introduced.