Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better handle CSV import via Places Import #740

Open
justin-bits opened this issue Aug 19, 2019 · 1 comment
Open

Better handle CSV import via Places Import #740

justin-bits opened this issue Aug 19, 2019 · 1 comment

Comments

@justin-bits
Copy link
Collaborator

CSV imports via Layers>Places are currently handled non-intuitively. KML is the expected format and is handled correctly. GeoJSON and SHP are not expected, but imported easily as features. CSV import throws a warning indicating that the file type could not be detected. Only after selecting CSV from the drop down can the file be imported as features.

  • Adjust file format detection to work with CSV (as it already does with GeoJSON and SHP)
  • [optional] Notify the user that the file contents will be imported as features, where the option then exists to save those features as places, OR ...
  • [optional] Give the user the ability to drop the contents in directly as places
swtyler pushed a commit to swtyler/opensphere that referenced this issue Oct 9, 2019
@brelsftm
Merge pull request ngageoint#740 in WV/opensphere from ~BRELSFORDT/op…
d5e1d11 
…ensphere:feature_linx-timeline to master

* commit '8b0e5a2507092cd28aa4f74f2604a4a3fcfab748':
  docs(timelinecontroller): fix spelling errors THIN-13290
  docs(timelinecontroller): Fix spelling mistake THIN-13290
  feat(timelinecontroller): seperate restore and reset THIN-13290
  feat(timelinecontroller): Add test for setting ranges, fix restoring states THIN-13290
@bradh
Copy link
Collaborator

bradh commented Feb 24, 2021

This doesn't appear to be CSV specific. I see the AnyTypeImportUI being used for GeoJSON (e.g. a local copy of https://docs.mapbox.com/help/data/stations.geojson) and SHP (e.g. an exported file from OpenSphere).

It looks like os.ui.im.ImportManager only knows about UIs for application/vnd.google-earth.kml+xml or application/vnd.google-earth.kmz (which go to plugin.places.KMLPlacesImportUI) and text/xml; subtype=filter (which goes to os.filter.im.OSFilterImportUI). Not sure that last one is going to work in Places Import, but that is probably a separate issue.

@bradh bradh mentioned this issue Feb 24, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(im): handle CSV import from Places tab bradh/opensphere
2 participants
@bradh @justin-bits