Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: use PORT env variable if provided instead of default (8080) #18

Merged
merged 1 commit into from
Apr 23, 2019
Merged

feat: use PORT env variable if provided instead of default (8080) #18

merged 1 commit into from
Apr 23, 2019

Conversation

medved-nsk
Copy link
Contributor

@medved-nsk medved-nsk commented Apr 23, 2019 •
edited by ngfelixl
Loading

I believe this change is useful and safe, taking in account the following:

  1. Port 8080 is often in use.
  2. Hardcoding is not a good practice (minor).
  3. It doesn't impact (I hope and tests are green :) previous version' behavior, so by default works the same way.

Closes #17

@coveralls
Copy link

coveralls commented Apr 23, 2019 •
edited
Loading

Pull Request Test Coverage Report for Build 117

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%
Totals Coverage Status
Change from base Build 116: 0.0%
Covered Lines: 98
Relevant Lines: 98
💛 - Coveralls

@ngfelixl ngfelixl mentioned this pull request Apr 23, 2019
Open
ngfelixl
ngfelixl approved these changes Apr 23, 2019
View reviewed changes
Copy link
Owner

@ngfelixl ngfelixl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for your submit :)

@ngfelixl ngfelixl merged commit 9ef2217 into ngfelixl:master Apr 23, 2019
ngfelixl added a commit that referenced this pull request Apr 23, 2019
@ngfelixl
Merge pull request #18 from medved-nsk/feat-optional-server-port
6298710 
feat: use PORT env variable if provided instead of default (8080)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ngfelixl ngfelixl ngfelixl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

spawn ENOENT error
3 participants
@medved-nsk @coveralls @ngfelixl