Move the self ID retrieval to /app/functions.sh #382
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JrCs
reviewed
May 19, 2018
|
It is but A better approach might be to save and export the result of |
Fix nginx-proxy#375 This enable the /app/force_renew script to get the LE companion container ID, which is required to check if the nginx container is running (nginx-proxy#321) when using the --volumes-from method.
JrCs
approved these changes
May 20, 2018
bingozb
pushed a commit
to bingozb/docker-letsencrypt-nginx-proxy-companion
that referenced
this pull request
Dec 4, 2019
Fix nginx-proxy#375 This enable the /app/force_renew script to get the LE companion container ID, which is required to check if the nginx container is running (nginx-proxy#321) when using the --volumes-from method.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fix for #375
This PR move the self ID retrieval to a reusable function, instead of a one time operation that stores the ID in an environment variable at container startup.
The
/app/force_renewscript being used throughdocker exec, it can't access this environment variable and therefore fails to check for a running nginx container (#321) when using the--volumes-frommethod.