Hardcode path to /app/letsencrypt_service_data #404
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JrCs
approved these changes
Jun 15, 2018
bingozb
pushed a commit
to bingozb/docker-letsencrypt-nginx-proxy-companion
that referenced
this pull request
Dec 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an attempt to fix #396 ("attempt to fix" because the circumstances under which the issue happen seems to be rather hard to reproduce reliably, so additional confirmation will be required).
From what I found, under those undetermined circumstances the
$DIRvariable ends up being empty, so theupdate_certsfunction returns without doing anything.Considering the limited use of this variable and the fact that
/appis already hardcoded in a lot of places, I think the safest fix is to hardcode the path/app/letsencrypt_service_data.