New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: experimental HTTP/3 support + optional HTTP/2 disabling #2278
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it is safe to change to $host
there is only 1 instance left in the $http_x_forwarded_proto
map.
I ran the tests with change and do not encounter any difference.
I re-organised the template a bit so that HTTP/3 related stuff is a bit more grouped together. More importantly I moved the I also removed the And finally I replaced the last |
👍 Will try to push later when at office and then you can improve or discard😅 cool this PR is getting along! Hopefully it helps more people to enable QUIC and maybe it encourages to use of this project as a early adopter. |
HSTS override tests, http2 & http3 tests: SchoNie@618da60 |
@SchoNie sorry for the lack of activity on august, the tests looked interesting, do you still have them ? |
c9b2f3f
to
337d444
Compare
Co-authored-by: Nicolas Duchon <nicolas.duchon@gmail.com> Co-authored-by: Knapoc <Knapoc@users.noreply.github.com>
Co-authored-by: Nicolas Duchon <nicolas.duchon@gmail.com> Co-authored-by: Niek <100143256+SchoNie@users.noreply.github.com>
Co-authored-by: Nicolas Duchon <nicolas.duchon@gmail.com> Co-authored-by: Patrick Domack <patrickdk@patrickdk.com>
Co-authored-by: Nicolas Duchon <nicolas.duchon@gmail.com> Co-authored-by: Niek <100143256+SchoNie@users.noreply.github.com>
@SchoNie I went the extra mile and opened a draft PR with what I got so far. It seems mostly functional to me, let me know if you think something is missing / should be done differently.
It indeed work when replacing
proxy_set_header Host $http_host;
withproxy_set_header Host $host;
, should we also replace the other uses of$http_host
beside this one ?The PR still lacks documentation at this point, and I don't think it can be automatically tested beside parsing the rendered template (Python's
request
is not even capable of doing HTTP/2).New labels on the proxied containers:
com.github.nginx-proxy.nginx-proxy.http2.enable
:enable HTTP/2 support when set to
true
(default:true
)com.github.nginx-proxy.nginx-proxy.http3.enable
:enable HTTP/3 support when set to
true
(default:false
)New environment variables on the proxy container:
ENABLE_HTTP2
: globally enable HTTP/2 when set totrue
(default:true
)ENABLE_HTTP3
: globally enable HTTP/3 when set totrue
(default:false
)closes #2170
closes #1055