-
Notifications
You must be signed in to change notification settings - Fork 101
Expand Config Apply Integration Tests #1246
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't think we need to add test numbers in test names e.g. TestConfigApply_Test4_TestInvalidConfig. Names should be enough TestConfigApply_InvalidConfig,
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Discussed in office - Test Suites run in alphabetical order so to get the tests to run in specific order need to be numbered.
Proposed changes
Checklist
Before creating a PR, run through this checklist and mark each as complete.
CONTRIBUTING
documentmake install-tools
and have attached any dependency changes to this pull requestREADME.md
)