Skip to content

Added version regex to parse the logs to see if matches vsemvar format #747

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 15, 2024
Merged

Added version regex to parse the logs to see if matches vsemvar format #747

merged 3 commits into from
Jul 15, 2024

Conversation

oliveromahony
Copy link
Contributor

@oliveromahony oliveromahony commented Jul 15, 2024 •
edited
Loading

Proposed changes

Add integration test for checking Agent starts with correct version string

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING document
  • I have run make install-tools and have attached any dependency changes to this pull request
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • If applicable, I have checked that any relevant tests pass after adding my changes
  • If applicable, I have updated any relevant documentation (README.md)
  • If applicable, I have tested my cross-platform changes on Ubuntu 22, Redhat 8, SUSE 15 and FreeBSD 13

@github-actions github-actions bot added the chore Pull requests for routine tasks label Jul 15, 2024
@oliveromahony oliveromahony changed the title Version Added version regex to parse the logs to see if matches vsemvar format Jul 15, 2024
dhurley
dhurley approved these changes Jul 15, 2024
View reviewed changes
@oliveromahony @dhurley
Update test/integration/utils/test_container_utils.go
22741d6 
Co-authored-by: Donal Hurley <djhurley1990@gmail.com>
@oliveromahony oliveromahony merged commit a6db6db into main Jul 15, 2024
@oliveromahony oliveromahony deleted the version branch July 15, 2024 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhurley dhurley dhurley approved these changes

@aphralG aphralG aphralG approved these changes

@craigell craigell Awaiting requested review from craigell

@spencerugbo spencerugbo Awaiting requested review from spencerugbo

+1 more reviewer

@olli-holmala olli-holmala olli-holmala approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@dhurley dhurley

@craigell craigell

@olli-holmala olli-holmala

@spencerugbo spencerugbo

@aphralG aphralG

Labels
chore Pull requests for routine tasks
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@oliveromahony @dhurley @olli-holmala @aphralG @craigell @spencerugbo