Skip to content

Conversation

alessfg
Copy link
Member

@alessfg alessfg commented Dec 3, 2021

Proposed changes

BREAKING CHANGES:

  • The nginx_state variable has been replaced with nginx_setup and instead of using present, absent, latest you should now use install, uninstall and update.
  • nginx_install variable is no more. Use nginx_enable instead.

BUG FIXES:

Uninstalling NGINX should now work correctly under most scenarios.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING document
  • I have added Molecule tests that prove my fix is effective or that my feature works
  • I have checked that any relevant Molecule tests pass after adding my changes
  • I have updated any relevant documentation (defaults/main/*.yml, README.md and CHANGELOG.md)

@alessfg alessfg self-assigned this Dec 3, 2021
@github-actions github-actions bot added the breaking change Implies a breaking change label Dec 3, 2021
@alessfg alessfg added the bug Something isn't working label Dec 3, 2021
@alessfg alessfg added this to the 0.21.4 milestone Dec 3, 2021
@alessfg alessfg merged commit 5f1fc18 into main Dec 7, 2021
@alessfg alessfg deleted the uninstall-nginx branch December 7, 2021 01:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change Implies a breaking change bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants