Add ingress2gateway information in Getting Started guide #1056
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
documentation
bjee19
requested changes
Sep 3, 2025
added 2 commits
September 3, 2025 12:32
bjee19
reviewed
Sep 3, 2025
salonichf5
reviewed
Sep 3, 2025
salonichf5
reviewed
Sep 3, 2025
salonichf5
approved these changes
Sep 4, 2025
|
FYI: You also need one review from docs team to check language and formatting |
bjee19
reviewed
Sep 4, 2025
bjee19
reviewed
Sep 4, 2025
Co-authored-by: bjee19 <139261241+bjee19@users.noreply.github.com>
bjee19
approved these changes
Sep 5, 2025
|
@ADubhlaoich Do you think this makes sense where it is? |
ADubhlaoich
approved these changes
Sep 10, 2025
There was a problem hiding this comment.
Generally LGTM: I've made some edit suggestions
If this is a use case we want to push, it shouldn't be buried in the Get started guide. It should probably be in the install section, and include some detail about why someone would want to do this, and what the differences between the Ingress and Gateway APIs are.
Co-authored-by: Alan Dooley <github@adubhlaoi.ch>
Co-authored-by: Alan Dooley <github@adubhlaoi.ch>
JTorreG
approved these changes
Sep 10, 2025
Co-authored-by: Alan Dooley <github@adubhlaoi.ch>
looks good to me and all your suggestions applied @ADubhlaoich |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Add ingress2gateway information in Getting Started guide
Checklist
Before sharing this pull request, I completed the following checklist:
Footnotes
Potentially sensitive information includes personally identify information (PII), authentication credentials, and live URLs. Refer to the style guide for guidance about placeholder content. ↩