Skip to content

Conversation

mjang
Copy link
Contributor

@mjang mjang commented Oct 2, 2025

Proposed changes

As discussed in an internal PR (248)

  • note: the content in the internal PR has 3 approvals.
  • Will proceed with merge as soon as this feature has been pushed to production

Checklist

Before sharing this pull request, I completed the following checklist:

Footnotes

  1. Potentially sensitive information includes personally identify information (PII), authentication credentials, and live URLs. Refer to the style guide for guidance about placeholder content.

@github-actions github-actions bot added documentation Improvements or additions to documentation product/nginx-one Issues related to NGINX One Console labels Oct 2, 2025
Copy link

github-actions bot commented Oct 2, 2025

Deploy Preview will be available once build job completes!

Name Link
😎 Deploy Preview https://frontdoor-test-docs.nginx.com/previews/docs/1233/

@vrmare
Copy link
Contributor

vrmare commented Oct 2, 2025

Looks good to me.

@mjang mjang force-pushed the feat-release-n1-console-templates-r1 branch from e28155b to fe985c9 Compare October 2, 2025 21:07
@mjang mjang marked this pull request as ready for review October 2, 2025 21:10
@mjang mjang requested review from a team as code owners October 2, 2025 21:10
mjang and others added 2 commits October 2, 2025 16:07
Co-authored-by: Travis Martin <33876974+travisamartin@users.noreply.github.com>
@mjang
Copy link
Contributor Author

mjang commented Oct 2, 2025

Accepted comments from @travisamartin

Since feature was merged about an hour ago, also merging this PR, based on approvals in an internal repo

There is an open issue for any outstanding comments, mostly from the internal repo PR.

@mjang
Copy link
Contributor Author

mjang commented Oct 2, 2025

Open issue for docs for this topic: #1238

@mjang mjang merged commit 7666fd8 into main Oct 2, 2025
9 checks passed
@mjang mjang deleted the feat-release-n1-console-templates-r1 branch October 2, 2025 23:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation product/nginx-one Issues related to NGINX One Console
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants