Skip to content

Conversation

sylwang
Copy link
Contributor

@sylwang sylwang commented Oct 3, 2025

Proposed changes

Checklist

Before sharing this pull request, I completed the following checklist:

Footnotes

  1. Potentially sensitive information includes personally identify information (PII), authentication credentials, and live URLs. Refer to the style guide for guidance about placeholder content.

@sylwang sylwang requested a review from a team as a code owner October 3, 2025 19:17
@github-actions github-actions bot added documentation Improvements or additions to documentation product/nginx-one Issues related to NGINX One Console labels Oct 3, 2025
Copy link

github-actions bot commented Oct 3, 2025

✅ All required contributors have signed the F5 CLA for this PR. Thank you!
Posted by the CLA Assistant Lite bot.

Copy link

github-actions bot commented Oct 3, 2025

Deploy Preview will be available once build job completes!

Name Link
😎 Deploy Preview https://frontdoor-test-docs.nginx.com/previews/docs/1251/

@sylwang
Copy link
Contributor Author

sylwang commented Oct 3, 2025

I have hereby read the F5 CLA and agree to its terms

@sylwang
Copy link
Contributor Author

sylwang commented Oct 6, 2025

All the feedback can be found in this PR (from internal-docs): https://github.com/nginx/internal-docs/pull/253.

Copy link
Contributor

@mjang mjang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve with suggestions.

@sylwang sylwang requested a review from a team as a code owner October 7, 2025 19:38
sylwang and others added 8 commits October 7, 2025 12:38
Co-authored-by: Travis Martin <33876974+travisamartin@users.noreply.github.com>
Co-authored-by: Travis Martin <33876974+travisamartin@users.noreply.github.com>
Co-authored-by: Travis Martin <33876974+travisamartin@users.noreply.github.com>
Co-authored-by: Travis Martin <33876974+travisamartin@users.noreply.github.com>
Co-authored-by: Travis Martin <33876974+travisamartin@users.noreply.github.com>
Co-authored-by: Travis Martin <33876974+travisamartin@users.noreply.github.com>
@sylwang sylwang force-pushed the n1-waf-signature-sets-release branch from 91cf65a to 86ada3f Compare October 7, 2025 19:39
@sylwang sylwang merged commit f714583 into main Oct 7, 2025
9 checks passed
@sylwang sylwang deleted the n1-waf-signature-sets-release branch October 7, 2025 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation product/nginx-one Issues related to NGINX One Console
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants