Skip to content

Conversation

mjang
Copy link
Contributor

@mjang mjang commented Dec 30, 2024

Proposed changes

This PR incorporates previously approved changes from the internal repository. I've reviewed them for PII.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the contributing guidelines.

  • I have signed the F5 Contributor License Agreement (CLA).

  • If applicable, I have added tests that prove my fix is effective or that my feature works.

  • If applicable, I have checked that any relevant tests pass after adding my changes.

  • I have updated any relevant documentation (README.md and CHANGELOG.md).

  • I have rebased my branch onto main

  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

  • If the change involves:

    • Code
    • Anything that resembles Personally identifying information (PII)
      • Make sure to use placeholders such as <username> in place of PII
    • URLs (watch for typosquatting)
    • Significant new/revised content

    In these cases, the change will require at least two (2) approvals before merging.

@mjang mjang requested a review from a team as a code owner December 30, 2024 15:30
@mjang
Copy link
Contributor Author

mjang commented Dec 30, 2024

Merging previously approved content from a different repository

@mjang mjang merged commit 5690c59 into main Dec 30, 2024
3 of 5 checks passed
@mjang mjang deleted the dec-30-updates branch December 30, 2024 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant