Skip to content

feat: Add closed contribution process #316

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Mar 27, 2025
Merged

Conversation

ADubhlaoich
Copy link
Contributor

Proposed changes

This commit adds a new document to explain the closed contribution process. As part of the changes, related content is updated from the existing documentation specific to F5 employees, decoupling this particular use case from general guidance.

At a future point, both documents may be reorganised into alternate files as part of peripheral efforts to document ways of working.

Checklist

Before merging a pull request, run through this checklist and mark each as complete.

  • I have read the contributing guidelines
  • I have signed the F5 Contributor License Agreement (CLA)
  • I have rebased my branch onto main
  • I have ensured my PR is targeting the main branch and pulling from my branch from my own fork
  • I have ensured that the commit messages adhere to Conventional Commits
  • I have ensured that documentation content adheres to the style guide
  • If the change involves potentially sensitive changes1, I have assessed the possible impact
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • I have ensured that existing tests pass after adding my changes
  • If applicable, I have updated README.md and CHANGELOG.md

Footnotes

  1. Potentially sensitive changes include anything involving code, personally identify information (PII), live URLs or significant amounts of new or revised documentation. Please refer to our style guide for guidance about placeholder content.

This commit adds a new document to explain the closed contribution
process. As part of the changes, related content is updated from the
existing documentation specific to F5 employees, decoupling this
particular use case from general guidance.

At a future point, both documents may be reorganised into alternate
files as part of peripheral efforts to document ways of working.
@ADubhlaoich ADubhlaoich requested a review from a team as a code owner March 26, 2025 12:45
@github-actions github-actions bot added the process documentation Documentation related to how the repository or documention itself is managed. label Mar 26, 2025
Copy link

Deploy Preview will be available once build job completes!

Name Link
😎 Deploy Preview https://frontdoor-test-docs.nginx.com/previews/docs/316/

Copy link
Contributor

@mjang mjang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We needed this, thanks @ADubhlaoich . I appreciate your attention to these comments.

Co-authored-by: Mike Jang <3287976+mjang@users.noreply.github.com>
Copy link
Contributor

@mjang mjang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changing review from "Request changes" to "Comment"

@ADubhlaoich ADubhlaoich requested a review from mjang March 26, 2025 15:21
@ADubhlaoich ADubhlaoich merged commit 0b25467 into main Mar 27, 2025
9 checks passed
@ADubhlaoich ADubhlaoich deleted the docs/add-closed-process branch March 27, 2025 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
process documentation Documentation related to how the repository or documention itself is managed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants