Skip to content

Conversation

mjang
Copy link
Contributor

@mjang mjang commented Jan 3, 2025

Proposed changes

Merging previously approved internal changes. Here's where the changes appear:

Please focus on (optional): If you any specific areas where you would like reviewers to focus their attention or provide
specific feedback, add them here.

If this PR addresses an issue on GitHub, ensure that you link to it here:

Closes #ISSUE

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the contributing guidelines

  • I have signed the F5 Contributor License Agreement (CLA)

  • If applicable, I have added tests that prove my fix is effective or that my feature works

  • If applicable, I have checked that any relevant tests pass after adding my changes

  • I have updated any relevant documentation (README.md and CHANGELOG.md)

  • I have rebased my branch onto main

  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

  • If the change involves:

    • Code
    • Anything that resembles Personally identifying information (PII)
      • Make sure to use placeholders such as <username> in place of PII
    • URLs (watch for typosquatting)
    • Significant new/revised content

    In these cases, the change will require at least two (2) approvals before merging

@mjang mjang self-assigned this Jan 3, 2025
@mjang mjang marked this pull request as ready for review January 3, 2025 21:47
@mjang mjang requested a review from a team as a code owner January 3, 2025 21:47
@mjang mjang merged commit 7dfe6de into main Jan 3, 2025
4 of 5 checks passed
@mjang mjang deleted the updates-from-internal-jan-3-1pm branch January 3, 2025 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants