Skip to content

Conversation

mkingst
Copy link
Contributor

@mkingst mkingst commented Jan 6, 2025

Proposed changes

Problem: To configure OpenID Connect with Keycloak for NIM authentication, there are new instructions for Keycloak >18 due to UI changes on the latest version.

Solution: We added those new steps in the documentation.

Testing: Instructions validated and tested by dev and qe

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the contributing guidelines

  • I have signed the F5 Contributor License Agreement (CLA)

  • If applicable, I have added tests that prove my fix is effective or that my feature works

  • If applicable, I have checked that any relevant tests pass after adding my changes

  • I have updated any relevant documentation (README.md and CHANGELOG.md)

  • I have rebased my branch onto main

  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

  • If the change involves:

    • Code
    • Anything that resembles Personally identifying information (PII)
      • Make sure to use placeholders such as <username> in place of PII
    • URLs (watch for typosquatting)
    • Significant new/revised content

    In these cases, the change will require at least two (2) approvals before merging

@mkingst mkingst requested a review from a team as a code owner January 6, 2025 12:59
Copy link

github-actions bot commented Jan 6, 2025

🎉 Thank you for your contribution! It appears you have not yet signed the F5 Contributor License Agreement (CLA), which is required for your changes to be incorporated into an F5 Open Source Software (OSS) project. Please kindly read the F5 CLA and reply on a new comment with the following text to agree:


I have hereby read the F5 CLA and agree to its terms


1 out of 2 committers have signed the CLA.
✅ (travisamartin)[https://github.com/travisamartin]
@mkingst
You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot.

Copy link

github-actions bot commented Jan 6, 2025

Deploy Preview will be available once build job completes!

Name Link
😎 Deploy Preview https://frontdoor-test-docs.nginx.com/previews/docs/45/

Copy link
Contributor Author

@mkingst mkingst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thank you!

@travisamartin travisamartin merged commit cca54df into main Jan 6, 2025
3 of 5 checks passed
@travisamartin travisamartin deleted the mkingst-keycloak-updates-oidc branch January 6, 2025 20:49
@travisamartin travisamartin added the product/nim Issues related to NGINX Instance Manager label Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

product/nim Issues related to NGINX Instance Manager

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants