Skip to content

Conversation

mjang
Copy link
Contributor

@mjang mjang commented Jan 8, 2025

Proposed changes

Fix outdated NGINX One documentation around data plane key deletion (steps through the console workflow, rather than documenting an API-only solution).

Clarify NGINX Agent installation in NGINX One documentation, primarily around necessary firewall permissions.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the contributing guidelines

  • I have signed the F5 Contributor License Agreement (CLA)

  • If applicable, I have added tests that prove my fix is effective or that my feature works

  • If applicable, I have checked that any relevant tests pass after adding my changes

  • I have updated any relevant documentation (README.md and CHANGELOG.md)

  • I have rebased my branch onto main

  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

  • If the change involves:

    • Code
    • Anything that resembles Personally identifying information (PII)
      • Make sure to use placeholders such as <username> in place of PII
    • URLs (watch for typosquatting)
    • Significant new/revised content

    In these cases, the change will require at least two (2) approvals before merging

Copy link

github-actions bot commented Jan 8, 2025

Deploy Preview will be available once build job completes!

Name Link
😎 Deploy Preview https://frontdoor-test-docs.nginx.com/previews/docs/53/

Copy link
Contributor

@ADubhlaoich ADubhlaoich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@JTorreG JTorreG marked this pull request as ready for review January 8, 2025 16:24
@JTorreG JTorreG requested review from a team as code owners January 8, 2025 16:24
@JTorreG JTorreG merged commit 904bde5 into main Jan 8, 2025
4 of 5 checks passed
@JTorreG JTorreG deleted the n1-doc-updates branch January 8, 2025 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants