Skip to content

Conversation

nginx-aoife
Copy link
Contributor

@nginx-aoife nginx-aoife commented Jan 9, 2025

Fix broken link in nginx-app-protect-waf

Proposed changes

Problem: Automation found broken link in nginx-app-protect-waf docs. https://github.com/nginx/documentation/actions/runs/12685140469/job/35354980039
Possibly caused by Azure content update.

Solution: URL is updated.

Testing: Local testing, URL opens correctly. No more 404

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the contributing guidelines

  • I have signed the F5 Contributor License Agreement (CLA)

  • If applicable, I have added tests that prove my fix is effective or that my feature works

  • If applicable, I have checked that any relevant tests pass after adding my changes

  • I have updated any relevant documentation (README.md and CHANGELOG.md)

  • I have rebased my branch onto main

  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

  • If the change involves:

    • Code
    • Anything that resembles Personally identifying information (PII)
      • Make sure to use placeholders such as <username> in place of PII
    • URLs (watch for typosquatting)
    • Significant new/revised content

    In these cases, the change will require at least two (2) approvals before merging

Fix broken link
@nginx-aoife nginx-aoife requested a review from a team as a code owner January 9, 2025 09:59
Copy link

github-actions bot commented Jan 9, 2025

✅ All required contributors have signed the F5 CLA for this PR. Thank you!
Posted by the CLA Assistant Lite bot.

Copy link

github-actions bot commented Jan 9, 2025

Deploy Preview will be available once build job completes!

Name Link
😎 Deploy Preview https://frontdoor-test-docs.nginx.com/previews/docs/56/

@nginx-aoife
Copy link
Contributor Author

I have hereby read the F5 CLA and agree to its terms

Copy link
Contributor

@ADubhlaoich ADubhlaoich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM though I have added an edit suggestion to use a Hugo reference.

These are docsets living together in the same codebase, so it doesn't make much sense to use a live URL to link between documents.

@nginx-aoife nginx-aoife merged commit 2f1a5f3 into main Jan 10, 2025
4 of 5 checks passed
@nginx-aoife nginx-aoife deleted the bug-fix-link branch January 10, 2025 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants