-
Notifications
You must be signed in to change notification settings - Fork 114
feat: NGINX One Console use-case based home page #595
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview will be available once build job completes!
|
e2c7f1c
to
5bb6ac1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally LGTM: I'd draw the custom card set-up to Docs Engineering's attention.
improvement
: is not a valid prefix per conventional commits: it would be feat
.
https://www.conventionalcommits.org/en/v1.0.0/#summary
Mostly inconsequential until merge.
FYI, that's in work with appropriate managers/PMs |
f27665c
to
c99cb20
Compare
2d3b7c0
to
338eb92
Compare
content/includes/use-cases/monitoring/n1c-dashboard-overview.md
Outdated
Show resolved
Hide resolved
content/includes/use-cases/monitoring/n1c-dashboard-overview.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Travis Martin <33876974+travisamartin@users.noreply.github.com>
5b5ee46
to
6defad9
Compare
Check warning
Code scanning / CodeQL
DOM text reinterpreted as HTML Medium generated
DOM text
Check warning
Code scanning / CodeQL
DOM text reinterpreted as HTML Medium generated
DOM text
DOM text
Check warning
Code scanning / CodeQL
DOM text reinterpreted as HTML Medium generated
DOM text
Check warning
Code scanning / CodeQL
DOM text reinterpreted as HTML Medium generated
DOM text
Superseded by #628 (and merged through that PR) |
Proposed changes
Write a clear and concise description that helps reviewers understand the purpose and impact of your changes. Use the
following format:
Problem: Give a brief overview of the problem or feature being addressed.
Solution: Explain the approach you took to implement the solution, highlighting any significant design decisions or
considerations.
Testing: Describe any testing that you did.
Please focus on (optional): If you any specific areas where you would like reviewers to focus their attention or provide
specific feedback, add them here.
If this PR addresses an issue on GitHub, ensure that you link to it here:
Closes #ISSUE
Checklist
Before merging a pull request, run through this checklist and mark each as complete.
README.md
andCHANGELOG.md
Footnotes
Potentially sensitive changes include anything involving code, personally identify information (PII), live URLs or significant amounts of new or revised documentation. Please refer to our style guide for guidance about placeholder content. ↩