Skip to content

Conversation

mjang
Copy link
Contributor

@mjang mjang commented May 23, 2025

Proposed changes

Write a clear and concise description that helps reviewers understand the purpose and impact of your changes. Use the
following format:

Problem: Give a brief overview of the problem or feature being addressed.

Solution: Explain the approach you took to implement the solution, highlighting any significant design decisions or
considerations.

Testing: Describe any testing that you did.

Please focus on (optional): If you any specific areas where you would like reviewers to focus their attention or provide
specific feedback, add them here.

If this PR addresses an issue on GitHub, ensure that you link to it here:

Closes #ISSUE

Checklist

Before merging a pull request, run through this checklist and mark each as complete.

  • I have read the contributing guidelines
  • I have signed the F5 Contributor License Agreement (CLA)
  • I have rebased my branch onto main
  • I have ensured my PR is targeting the main branch and pulling from my branch from my own fork
  • I have ensured that the commit messages adhere to Conventional Commits
  • I have ensured that documentation content adheres to the style guide
  • If the change involves potentially sensitive changes1, I have assessed the possible impact
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • I have ensured that existing tests pass after adding my changes
  • If applicable, I have updated README.md and CHANGELOG.md

Footnotes

  1. Potentially sensitive changes include anything involving code, personally identify information (PII), live URLs or significant amounts of new or revised documentation. Please refer to our style guide for guidance about placeholder content.

@mjang mjang requested review from a team as code owners May 23, 2025 19:15
@github-actions github-actions bot added documentation Improvements or additions to documentation product/nginx-one Issues related to NGINX One Console tooling Back end, repository, Hugo, and all things not related to content labels May 23, 2025
Copy link

Deploy Preview will be available once build job completes!

Name Link
😎 Deploy Preview https://frontdoor-test-docs.nginx.com/previews/docs/595/

@mjang mjang force-pushed the nginx-one-new-homepage branch from e2c7f1c to 5bb6ac1 Compare May 23, 2025 21:09
Copy link
Contributor

@ADubhlaoich ADubhlaoich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally LGTM: I'd draw the custom card set-up to Docs Engineering's attention.

improvement: is not a valid prefix per conventional commits: it would be feat.

https://www.conventionalcommits.org/en/v1.0.0/#summary

Mostly inconsequential until merge.

@mjang
Copy link
Contributor Author

mjang commented May 27, 2025

Generally LGTM: I'd draw the custom card set-up to Docs Engineering's attention.

FYI, that's in work with appropriate managers/PMs

@mjang mjang changed the title improvement: NGINX One Console use-case based home page feat: NGINX One Console use-case based home page May 27, 2025
@mjang mjang force-pushed the nginx-one-new-homepage branch from f27665c to c99cb20 Compare May 27, 2025 20:27
@mjang mjang self-assigned this May 27, 2025
@mjang mjang force-pushed the nginx-one-new-homepage branch from 2d3b7c0 to 338eb92 Compare May 28, 2025 21:12
@mjang mjang force-pushed the nginx-one-new-homepage branch from 5b5ee46 to 6defad9 Compare May 29, 2025 17:31

Check warning

Code scanning / CodeQL

DOM text reinterpreted as HTML Medium generated

DOM text
is reinterpreted as HTML without escaping meta-characters.

Check warning

Code scanning / CodeQL

DOM text reinterpreted as HTML Medium generated

DOM text
is reinterpreted as HTML without escaping meta-characters.
DOM text
is reinterpreted as HTML without escaping meta-characters.

Check warning

Code scanning / CodeQL

DOM text reinterpreted as HTML Medium generated

DOM text
is reinterpreted as HTML without escaping meta-characters.

Check warning

Code scanning / CodeQL

DOM text reinterpreted as HTML Medium generated

DOM text
is reinterpreted as HTML without escaping meta-characters.
@mjang
Copy link
Contributor Author

mjang commented May 30, 2025

Superseded by #628 (and merged through that PR)

@mjang mjang closed this May 30, 2025
@ADubhlaoich ADubhlaoich deleted the nginx-one-new-homepage branch July 3, 2025 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation product/nginx-one Issues related to NGINX One Console tooling Back end, repository, Hugo, and all things not related to content
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants